data icon indicating copy to clipboard operation
data copied to clipboard

fix(deps): update dependency @hono/node-server to v1.4.1 [security]

Open renovate[bot] opened this issue 2 years ago • 0 comments

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@hono/node-server 1.3.3 -> 1.4.1 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-23340

Impact

Since v1.3.0, we use our own Request object. This is great, but the url behavior is unexpected.

In the standard API, if the URL contains .., here called "double dots", the URL string returned by Request will be in the resolved path.

const req = new Request('http://localhost/static/../foo.txt') // Web-standards
console.log(req.url) // http://localhost/foo.txt

However, the url in our Request does not resolve double dots, so http://localhost/static/.. /foo.txt is returned.

const req = new Request('http://localhost/static/../foo.txt')
console.log(req.url) // http://localhost/static/../foo.txt

It will pass unresolved paths to the web application. This causes vulnerabilities like #​123 when using serveStatic.

Note: Modern web browsers and a latest curl command resolve double dots on the client side, so it does not affect you if the user uses them. However, problems may occur if accessed by a client that does not resolve them.

Patches

"v1.4.1" includes the change to fix this issue.

Workarounds

Don't use serveStatic.


Release Notes

honojs/node-server (@​hono/node-server)

v1.4.1

Compare Source

What's Changed

Full Changelog: https://github.com/honojs/node-server/compare/v1.4.0...v1.4.1

v1.4.0

Compare Source

What's Changed

Full Changelog: https://github.com/honojs/node-server/compare/v1.3.5...v1.4.0

v1.3.5

Compare Source

What's Changed

Full Changelog: https://github.com/honojs/node-server/compare/v1.3.4...v1.3.5

v1.3.4

Compare Source

What's Changed

Full Changelog: https://github.com/honojs/node-server/compare/v1.3.3...v1.3.4


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

renovate[bot] avatar Feb 25 '24 10:02 renovate[bot]