data icon indicating copy to clipboard operation
data copied to clipboard
verified publisher icon emberjs

[DOC] JSONAPIAdapter's findMany

Open sly7-7 opened this issue 6 years ago • 5 comments

sly7-7 avatar Nov 27 '19 10:11 sly7-7

Hi! Can you address the linting errors?

locks avatar Jan 31 '20 01:01 locks

@locks Is it good enough now ?

sly7-7 avatar Jan 31 '20 16:01 sly7-7

@locks, I'm sorry, I don't understand the @staticthing here, because this method is not a static one. 😕

sly7-7 avatar Mar 09 '20 09:03 sly7-7

The Ember Data tests verify that the "table of contents" for API documentation did not change. Since you are introducing findMany by documenting it, you need to tell https://github.com/emberjs/data/blob/master/packages/-ember-data/node-tests/fixtures/expected.js to expect findMany!

locks avatar Mar 25 '20 17:03 locks

Sorry for the noise, I think I've been too much agressive during my housekeeping...

sly7-7 avatar May 26 '21 15:05 sly7-7

Closing due to focus on the request manager going forward. Thanks for contributing!

locks avatar Aug 04 '23 15:08 locks