data icon indicating copy to clipboard operation
data copied to clipboard

Accidental addon overrides

Open runspired opened this issue 9 years ago • 2 comments

There's a known issue with ember-cli where any addon can clobber other addon or app's version of an addon by specifying the addon as a dependency being the "last in". I recently hit this with an addon locking to 2.10 while the app was on 2.12 canary, but it was difficult to spot because the version number printed in the console was still (incorrectly) the canary version (pulled from package.json). Had I not known the internals code, I would not have spotted this as my issue.

We should ensure we print the correct version number.

@rwjblue also suggested I add a build check to ensure an addon cant clobber the parent app's version of Ember-Data.

runspired avatar Dec 22 '16 00:12 runspired

Do you know how hard it would be to add the anti clobbering assertion? cc @rwjblue

igorT avatar Jun 05 '20 12:06 igorT

@igorT this is actually the infra we just added to emebr-cli-version-checker for highlander checks, I'll be PRing using it to EmberData and helping back port it to 3.12, 3.16 and stable pretty soon :)

runspired avatar Jun 05 '20 18:06 runspired

With proper peer-dependencies now specified (and locked) this is no longer required.

runspired avatar Mar 27 '23 23:03 runspired