Update 07-reusable-components.md
@chriskrycho the typescript part of the release goes wrong. It does not seem related to this PR at all, do you know what's up?
See #217. This doesn't seem to always happen – as of today I was still able to sign up for a new account, and other than verifying the email address I wasn't asked to put in my credit card. We may also want to point out that the readers can proceed without a valid token if they don't feel like signing up. How about –
-
~~
You can [sign up](https://www.mapbox.com/signup/) for free and without a credit card.~~ ->You can [sign up here](https://www.mapbox.com/signup/). -
Add a Zoey says... to the effect of...
The sign up process sometimes require a credit card, but the usage for this project is expected to be well within the free tire. Alternatively, you can skip this step and use a placeholder token in the subsequent step (such as
"invalid-token"). If you choose to do this, the maps will not render and you will see "broken image" icons in their place, but the tests will pass, allowing you to still follow the rest of the tutorial.
How does that sound?
@MinThaMie the typescript stuff does matter – the code for building the tutorial is written in typescript and so that part of the CI pipeline is to compile them into JS (stripping the types) so node can run them.
Looking at the logs:
- last "successful" build: https://github.com/ember-learn/super-rentals-tutorial/actions/runs/3042014396
- first failing build: https://github.com/ember-learn/super-rentals-tutorial/actions/runs/3049790487/jobs/4916210279
(The "successful" build was failing for a different reason – an ember data deprecation, there were some discussions about this in the meta channel a while back)
It seems like, we have an indirect dependency on @types/express-serve-static-core and somehow its index.d.ts is tripping up the compiler with syntax errors. We are on a fairly old typescript version so perhaps that is not super surprising, but then we are also using yarn with a lockfile, so I am not sure why that would suddenly fail.
So we will have to either troubleshoot what's going on in the CI server or upgrade TS + some of the deps? Perhaps that's something @chriskrycho can help with indeed (or at least knows someone who could). The code is here and it's around a few hundred lines of vanilla typescript, so it probably won't be so bad?