guides-source icon indicating copy to clipboard operation
guides-source copied to clipboard

deps: install latest `guidemaker-ember-template` to switch to shiki

Open IgnaceMaes opened this issue 2 years ago • 1 comments

WIP until there's a new major release of guidemaker-ember-template.

Preview: https://deploy-preview-1997--ember-guides.netlify.app/release/routing/defining-your-routes/

IgnaceMaes avatar Jan 24 '24 21:01 IgnaceMaes

Deploy Preview for ember-guides ready!

Name Link
Latest commit e69dd5d477deed6ead45a05d06baab02125d2b61
Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/667bbbe563663600083c7f89
Deploy Preview https://deploy-preview-1997--ember-guides.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 24 '24 21:01 netlify[bot]

The breaking change since converting guidemaker and dependencies to a v2 addon is the Ember Data integration.

When switching a version via the dropdown it logs:

TypeError: Cannot read properties of undefined (reading 'queryRecord')

In guidemaker/controllers/version.

@mansona IIRC there were some Ember Data reexport magic in the v1 addon that were changed. Do you have an idea how to proceed here?

IgnaceMaes avatar Jun 14 '24 18:06 IgnaceMaes

Upgrading to the latest guidemaker patch fixed this 🎉

Should be ready to go now!

IgnaceMaes avatar Jun 26 '24 07:06 IgnaceMaes