eslint-plugin-ember icon indicating copy to clipboard operation
eslint-plugin-ember copied to clipboard
verified publisher icon ember-cli

'avoid-leaking-state-in-ember-objects' plugin -- controllers

Open lumenlunae opened this issue 8 years ago • 2 comments

Having trouble seeing how to follow the plugin guides and also the Emberjs.com guides for 2.18 -- https://guides.emberjs.com/v2.18.0/routing/query-params/

Should I set all query params as computed functions?

Or should the plugin skip Controller? Controllers are only used as singleton instances aren't they?

Thanks!

lumenlunae avatar Jan 17 '18 06:01 lumenlunae

Work around for now would be to do queryParams: Object.freeze(['category']) (taking the first example from the guides), but I do think that we should add queryParams to the default whitelist...

rwjblue avatar Jan 17 '18 13:01 rwjblue

I think this can be closed because I saw that queryParams are already in DEFAULT_IGNORED_PROPERTIES or do I miss something?

dennismende avatar May 25 '18 14:05 dennismende