proxy-pac-proxy icon indicating copy to clipboard operation
proxy-pac-proxy copied to clipboard

Allow file urls

Open sys-cf-ghrn opened this issue 7 years ago • 2 comments

Allows access to local files via file://

sys-cf-ghrn avatar Jul 06 '18 17:07 sys-cf-ghrn

Thanks for the PR, I understand the use case it is trying to address and believe it's doable. Unfortunately the patch as it stands cannot be practically merged, as most of the changes are editorial and would create inconsistencies with the coding style. I'm sure we can figure out pretty easily the minimum set of changes for supporting 'file://' URIs. Can you open an issue with a short description to track progress?

emarock avatar Jul 07 '18 07:07 emarock

Sorry, I applied my code formatter to your files because they were unreadable in my editor. There appears to be a mixture of tabs and spaces in your project. I've reverted them, but I'd consider using something like prettier across your project. You can configure it to match your code style.

Here's what it looks like in my editor. image

sys-cf-ghrn avatar Jul 09 '18 14:07 sys-cf-ghrn