elli icon indicating copy to clipboard operation
elli copied to clipboard
verified publisher icon elli-lib

fix request scheme, host and port in req record

Open tsloughter opened this issue 3 years ago • 4 comments

tsloughter avatar Feb 18 '22 23:02 tsloughter

Tests were failing on 21 because of the lack of uri_string, so I've ditched support of OTP-21. Fixes https://github.com/elli-lib/elli/issues/103

tsloughter avatar Feb 19 '22 20:02 tsloughter

I see dialyzer is mad too. I can probably take a look tonight.

yurrriq avatar Feb 22 '22 19:02 yurrriq

parse_path isn't meant to be a public api, but only for exported for tests, so I don't think this warrants a major version bump.

That said, you already started on a major version bump, right? I figured it would go with that anyway.

tsloughter avatar Feb 23 '22 22:02 tsloughter

parse_path isn't meant to be a public api, but only for exported for tests, so I don't think this warrants a major version bump.

I'm convinced.

That said, you already started on a major version bump, right? I figured it would go with that anyway.

We have this outdated one at least: https://github.com/elli-lib/elli/pull/102

yurrriq avatar Feb 24 '22 03:02 yurrriq