soap icon indicating copy to clipboard operation
soap copied to clipboard

soap_version/0 now loads :version 1.1 by default

Open waseigo opened this issue 2 years ago • 0 comments

In partial response to issue 88, I noticed that Soap fails completely if my application does not define config :soap, :globals in its config/config.exs, even though a) HTTPoison is the default client and b) version 1.1 is claimed in the documentation to be the default.

Applications using a dependency that itself depends on Soap should not need to add anything to their config/config.exs, especially if what is expected to be defined therein has a sane default value (version 1.1, and HTTPoison). Thus, I redefined soap_version/0 to first see if it can fetch its configuration; if not, it gracefully returns the (default, according to the docs) version 1.1.

Note that the test suite of Soap still assumes that config/config.exs contains a configuration. Removing these lines from it makes tests fail. It might be a good idea to get rid of this caveat entirely, and follow the official recommendation to avoid application configuration for libraries.

waseigo avatar Mar 07 '23 22:03 waseigo