nx icon indicating copy to clipboard operation
nx copied to clipboard
verified publisher icon elixir-nx

Add missing gradients

Open seanmor5 opened this issue 5 years ago • 5 comments

Currently missing gradients for these functions:

  • [x] Product
  • [ ] Scatter Window Max
  • [ ] Scatter Window Min
  • [x] Scatter Add
  • [x] LU Decomposition
  • [x] Triangular Solve
  • [x] SVD

seanmor5 avatar Jan 22 '21 01:01 seanmor5

https://github.com/tensorflow/tensorflow/pull/45475 https://github.com/tensorflow/tensorflow/issues/6504

This issue and Pull Request are related to QR grad. Might be relevant for who tackles this later. In the PR comments there's a paper related to backpropagation of QR and LQ factorizations.

polvalente avatar Mar 12 '21 17:03 polvalente

I believe that gradients for some of these functions have been implemented. Could you update the list @seanmor5 ?

Benjamin-Philip avatar Dec 02 '21 14:12 Benjamin-Philip

@Benjamin-Philip i recently updated the list and it should be good. If anything is missing, please let me know :)

josevalim avatar Dec 02 '21 14:12 josevalim

@josevalim, you're right! I remember seeing some completed gradients a few days ago. I did not realise that it was updated. My bad 🙂.

Benjamin-Philip avatar Dec 02 '21 15:12 Benjamin-Philip

I'm starting work on triangular solve gradient

polvalente avatar Dec 06 '21 16:12 polvalente