mint_web_socket icon indicating copy to clipboard operation
mint_web_socket copied to clipboard
verified publisher icon elixir-mint

Fix dialyzer issues

Open davydog187 opened this issue 3 years ago • 1 comments

Thanks for the great project! I originally heard about it on your episode of Thinking Elixir.

I pulled Mint.WebSocket into my project, and found a bunch of dialyzer issues. This PR aims to address all of the dialyzer issues, as well as adding to CI.

davydog187 avatar Sep 19 '22 21:09 davydog187

Pull Request Test Coverage Report for Build af9b5676d8bec085b57fa93016ce833474eeb7b7-PR-23

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.952%
Totals Coverage Status
Change from base Build 69ed3cc832b49aa8b56658818847bd41ad874be3: 0.0%
Covered Lines: 314
Relevant Lines: 353
💛 - Coveralls

coveralls avatar Sep 19 '22 22:09 coveralls

This has been taken care of in #27 so I will close this out, but thank you for your PR!

the-mikedavis avatar Dec 09 '22 01:12 the-mikedavis

Sorry I couldn't get back to this, but that's for resolving! @the-mikedavis

davydog187 avatar Feb 10 '23 20:02 davydog187