Remove or isolate call to private module/function Mix.Dep.load_on_environment/1

Open axelson opened this issue 6 years ago • 3 comments

It has been removed/changed in Elixir 1.9-dev.

Upstream issue: https://github.com/JakeBecker/elixir-ls/issues/155

Feb 28 '19 00:02 axelson

Looks like this has already been fixed, I had a look at this commit from the original branch. It seems like this Mix.Dep.loaded has correctly been changed to Mix.Dep.load_on_environment. Let me know if there is anything else I can do.

Dec 22 '20 08:12 Hanspagh

The idea behind this issue is to separate out the call to the private function Mix.Dep.load_on_environment/1 into a separate module, so if it changes in a future version of Elixir (which could happen in a point release), it is easy to update ElixirLS to match. Here's an example from ElixirSense: https://github.com/elixir-lsp/elixir_sense/blob/master/lib/elixir_sense/core/normalized/typespec.ex

Although the title of the issue was outdated which makes it a little confusing. I've updated the title for accuracy.

Dec 22 '20 18:12 axelson

I see, should not be too difficult fo fix then 👍

Dec 22 '20 21:12 Hanspagh

I don't think it's worth doing

Oct 06 '22 16:10 lukaszsamson