adbc icon indicating copy to clipboard operation
adbc copied to clipboard

Specify cross-compiler for Adbc

Open cocoa-xu opened this issue 2 years ago • 6 comments

Right now Adbc would always use /usr/bin/x86_64-linux-gnu-gcc as the compiler. I'll try it and see how do I specify cross-compiler for Adbc. We should be able to do that by specifying CMAKE_TOOLCHAIN_FILE.

cocoa-xu avatar Jul 14 '23 23:07 cocoa-xu

Actually, there is no need to build for other Linux targets than x86_64 because we're downloading official drivers which only have support for x86_64 Linux.

cocoa-xu avatar Jul 16 '23 02:07 cocoa-xu

Where are the drivers being downloaded from? They should build on Linux (x64/ARM), macOS (x64/ARM), and Windows (x64). We only provide binaries via conda-forge, and those packages don't yet build for Windows there (someone needs to figure out the CI issues).

lidavidm avatar Apr 12 '24 08:04 lidavidm

Where are the drivers being downloaded from? They should build on Linux (x64/ARM), macOS (x64/ARM), and Windows (x64). We only provide binaries via conda-forge, and those packages don't yet build for Windows there (someone needs to figure out the CI issues).

We currently download drivers from the release page, for example, https://github.com/apache/arrow-adbc/releases/tag/apache-arrow-adbc-0.11.0. These drivers are extracted from Python wheels.

cocoa-xu avatar Apr 12 '24 08:04 cocoa-xu

ah, good to know, thanks. Uh, I suppose that isn't the intended use, but if it works...

lidavidm avatar Apr 12 '24 08:04 lidavidm

ah, good to know, thanks. Uh, I suppose that isn't the intended use, but if it works...

Oh we were compiling these drivers at some point (hence the cc_toolchains directory in the repo), but I forgot if it was because it took too much time on CI or for other reasons, we decided to just use these drivers from Python wheels...

cocoa-xu avatar Apr 12 '24 09:04 cocoa-xu

@lidavidm it would be nice if we could have only the drivers (outside of the wheels) but due to ADBC's design, they just work, yeah, so at least for now we don't see a reason to. :)

josevalim avatar Apr 12 '24 09:04 josevalim

@cocoa-xu is this still relevant?

josevalim avatar Nov 12 '24 11:11 josevalim

@cocoa-xu is this still relevant?

Let's close this one as we probably won't build these drivers in this repo.

cocoa-xu avatar Nov 12 '24 11:11 cocoa-xu