pyelftools icon indicating copy to clipboard operation
pyelftools copied to clipboard
verified publisher icon eliben

pyelftools incorrectly decodign names of Note Types.

Open dethrophes opened this issue 10 years ago • 4 comments

NoteTypes are subtypes of NoteName. i.e. its only valid to use the current enum if the NoteName is GNU. I've added a patch to fix this to the fork I made . https://github.com/eliben/pyelftools/compare/master...dethrophes:master

A also improved the handling of the scenario when the PT_NOTE segment aren't exactly the size of the contained notes.

dethrophes avatar Sep 27 '15 19:09 dethrophes

Can you create a pull request?

eliben avatar Sep 27 '15 20:09 eliben

done.

On Sun, Sep 27, 2015 at 10:22 PM, Eli Bendersky [email protected] wrote:

Can you create a pull reques?

— Reply to this email directly or view it on GitHub https://github.com/eliben/pyelftools/issues/87#issuecomment-143592380.

dethrophes avatar Sep 27 '15 23:09 dethrophes

Have I missed your PR or was it accepted already?

eliben avatar Oct 16 '16 21:10 eliben

I think it was not send as PR. GitHub says those three top commits in their fork are "ahead" of origin/upstream/this repo: https://github.com/dethrophes/pyelftools/commits/master

disconnect3d avatar Jun 07 '20 14:06 disconnect3d