wp2static icon indicating copy to clipboard operation
wp2static copied to clipboard

DetectCustomPostTypeURLs returns URLs for almost all post types

Open Flynsarmy opened this issue 5 years ago • 1 comments

This is a problem because that includes built-in ones such as Post - making this detector return a potentially HUGE list of duplicate URLs to the DetectPostURLs detector.

There are a few things we could do here.

  • Exclude all built-in post types OR
  • Rename the class to DetectAllPostTypeURLs and just cover everything in this one class.

Flynsarmy avatar Sep 01 '20 00:09 Flynsarmy

Exclude all built-in post types

Would be my preference, to keep more granular control and allow users/addons to toggle it with filters

leonstafford avatar Sep 01 '20 01:09 leonstafford