website icon indicating copy to clipboard operation
website copied to clipboard
verified publisher icon elementary

Support dark style

Open cassidyjames opened this issue 6 years ago • 4 comments

Intended to fix #2192.

  • Adds several palette colors to be used elsewhere
  • Switches a couple of JPG references to PNGs

dark

  • [ ] Button styles
  • [x] Brand logomark backgrounds
  • [x] Get Involved tweaks
  • [x] Open Source chart and logo colors
  • [ ] Store popups are white-on-white
  • [ ] Language popover is always white

cassidyjames avatar May 16 '19 06:05 cassidyjames

Is this still open? I’d love to take the remaining tasks on. Any color preferences for buttons? or are those color vars already declared?

srprkr avatar Oct 02 '19 14:10 srprkr

@SeanRParker yes, this would still be great to get wrapped up! The main issue with the button styles is that the strokes/shadows are meant for a white background, so they look weird on dark backgrounds. We can use transparency (like I did here: https://github.com/elementary/blog-template/pull/11) to work around that, or we could provide separate button styles for the dark style; whichever makes the most sense.

cassidyjames avatar Oct 02 '19 14:10 cassidyjames

I don't typically run php so set up took me a bit on my macbook. I have things up though and the button looks good. I'd start on the #choice-buttons, but I got to get to bed. I hope to look at those next.

Screen Shot 2019-10-19 at 10 40 42 PM

srprkr avatar Oct 20 '19 02:10 srprkr

Screen Shot 2019-10-22 at 10 37 54 PM Screen Shot 2019-10-22 at 10 38 06 PM

PR for button dark button styles.

srprkr avatar Oct 23 '19 02:10 srprkr