installer icon indicating copy to clipboard operation
installer copied to clipboard

Installer support for non-512-byte sector sizes

Open vjr opened this issue 5 years ago • 3 comments

See https://github.com/pop-os/distinst/pull/181

Noticed this while working on https://github.com/elementary/installer/pull/447

vjr avatar Sep 12 '20 08:09 vjr

Looks like installer code already handles/uses the distinst disk get_sector_size () value, except for the https://github.com/elementary/installer/blob/master/src/Objects/Mount.vala class.

This may only be relevant for the EFI ESP partition size check, in the (rare?) occasion the sector size is not 512 bytes, so this issue is probably low priority.

vjr avatar Sep 12 '20 09:09 vjr

+1 With 4k sector size, a 256GB SSD is shown as a 32GB SSD With 4k sector size

Same SSD with 512b sector size With 512 sector size

dr-Styki avatar Dec 11 '20 11:12 dr-Styki