docs icon indicating copy to clipboard operation
docs copied to clipboard

Add copy about uninstalling the application

Open iancleary opened this issue 4 years ago • 6 comments

I've attempted to add some copy about uninstalling the application to address issue https://github.com/elementary/docs/issues/97.

I've compiled what I believe uninstalls the application, but I am following the tutorial while proposing these edits. So if one of the maintainers would advise/edit as needed, I'd be happy to update my branch.


Uninstalling the application

To uninstall your application, we need to remove the several files we've created outside of our project folder:

  • Binary file located at /usr/bin/com.github.yourusername.hello-again
  • Desktop file in /usr/share/applications/com.github.yourusername.hello-again.desktop
  • Application Data file in /usr/share/metainfo/com.github.yourusername.hello-again.appdata.xml
sudo rm /usr/bin/com.github.yourusername.hello-again
sudo rm /usr/share/applications/com.github.yourusername.hello-again.desktop
sudo rm /usr/share/metainfo/com.github.yourusername.hello-again.appdata.xml

iancleary avatar Sep 11 '21 21:09 iancleary

I'm not sure about Application Data, but doesn't sudo ninja uninstall inside the build folder removes the necessary files?

Eldhrimer avatar Oct 03 '21 07:10 Eldhrimer

It wasn't clear to me how to uninstall. I'd like the docs to state the method directly.

If sudo ninja uninstall from the build folder is the right way, I'd be happy to change the PR contents.

Is that the recommended way?

Thanks!

iancleary avatar Oct 03 '21 15:10 iancleary

@Eldhrimer sudo ninja uninstall from the build folder worked. I agree that is the preferred way forward.

Thanks! :)

sudo ninja uninstall
[0/1] /usr/bin/meson --internal uninstall
Deleted: /usr/bin/com.github.icancclearynow.nordvpn
Deleted: /usr/share/applications/com.github.icancclearynow.nordvpn.desktop
Deleted: /usr/share/metainfo/com.github.icancclearynow.nordvpn.appdata.xml
Deleted: /usr/share/icons/hicolor/16x16/apps/com.github.icancclearynow.nordvpn.svg
Deleted: /usr/share/icons/hicolor/16x16@2/apps/com.github.icancclearynow.nordvpn.svg
Deleted: /usr/share/icons/hicolor/24x24/apps/com.github.icancclearynow.nordvpn.svg
Deleted: /usr/share/icons/hicolor/24x24@2/apps/com.github.icancclearynow.nordvpn.svg
Deleted: /usr/share/icons/hicolor/32x32/apps/com.github.icancclearynow.nordvpn.svg
Deleted: /usr/share/icons/hicolor/32x32@2/apps/com.github.icancclearynow.nordvpn.svg
Deleted: /usr/share/icons/hicolor/48x48/apps/com.github.icancclearynow.nordvpn.svg
Deleted: /usr/share/icons/hicolor/48x48@2/apps/com.github.icancclearynow.nordvpn.svg
Deleted: /usr/share/icons/hicolor/64x64/apps/com.github.icancclearynow.nordvpn.svg
Deleted: /usr/share/icons/hicolor/64x64@2/apps/com.github.icancclearynow.nordvpn.svg
Deleted: /usr/share/icons/hicolor/128x128/apps/com.github.icancclearynow.nordvpn.svg
Deleted: /usr/share/icons/hicolor/128x128@2/apps/com.github.icancclearynow.nordvpn.svg
Deleted: /usr/share/glib-2.0/schemas/com.github.icancclearynow.nordvpn.gschema.xml

Uninstall finished.

Deleted: 16
Failed: 0

Remember that files created by custom scripts have not been removed.

I'll update the PR.

iancleary avatar Oct 04 '21 18:10 iancleary

Per https://github.com/elementary/docs/commit/8e6890010b7e5a458ea2b8db0a87ee44e7f53780, I edited the build system edits to use sudo ninja uninstall.

Per https://github.com/elementary/docs/pull/134/commits/4a747979560a586c780f499b64bb710e610db5c2, I added copy regarding the flatpak remove command.

Per https://github.com/elementary/docs/pull/134/commits/58a969a430a8f4ba8d6ec6f2e2b90844e92c1898, I added a link to Flatpak's documentation.

My edits are done are ready for review!

Thanks for the feedback 😊

iancleary avatar Oct 04 '21 19:10 iancleary

@Eldhrimer I removed the bash output per https://github.com/elementary/docs/commit/8ff32d85c43b45423fc92bb3ce95b455653d977a.

Does it look good to merge to you?

iancleary avatar Oct 13 '21 01:10 iancleary

@cassidyjames @Marukesu Thanks for the review!

I believe I've incorporate your suggestions or requested changes. Let me know if there is anything else you need.

iancleary avatar Mar 11 '22 01:03 iancleary

Sorry it took so long to get this merged. Nice work :)

You're welcome! Thanks for the merge 😊

iancleary avatar Mar 14 '23 20:03 iancleary