code icon indicating copy to clipboard operation
code copied to clipboard
verified publisher icon elementary

Fix highlighting after reselection of same word

Open jeremypw opened this issue 1 year ago • 1 comments

Fixes #1483

  • Ensure selection is updated in plugin when selection changes by clicking elsewhere
  • Simplify and DRY some code

Throttling the update-spaces function was tried but the resulting lag was found to be distracting so now they are updated straight-away as before. This is inefficient but any improvement can be left for another PR.

jeremypw avatar Oct 22 '24 17:10 jeremypw

@zeebok You may like to take a look at this and let me know if by any chance it also fixes the crashing problem we discussed.

jeremypw avatar Oct 22 '24 18:10 jeremypw

@zeebok I see what you mean. I have now separated the throttle for the selection change signal so that can be faster. Could you reproduce the crash on BackSpace issue with this PR?

jeremypw avatar Dec 02 '24 12:12 jeremypw

@jeremypw I will try to take a look at this review again this week!

zeebok avatar Jan 12 '25 19:01 zeebok

Converting to draft as there seems to be some code from the dogfood fork accidentally merged here!

jeremypw avatar Jan 24 '25 19:01 jeremypw