code Fix autosave during close

Fixes #1183

Block on source buffer async save instead of yield.

Apr 03 '22 17:04 vjr

Thanks @jeremypw for taking a look... I've tried a few things but when I've gotten the autosave to apparently work the SourceFileSaver appears to be leaving around files like .goutputstream-HU28J1 as if the save hasn't completed even though we're "blocking" for the save_async () call... Any ideas? I've tried placing a call to Posix.sync () to see if it helps but it does not.

Apr 05 '22 16:04 vjr

I'll see if I can come up with something.

Apr 06 '22 09:04 jeremypw

Just pushed a draft PR that makes more deep-rooted changes to the saving logic (which seems rather tangled at the moment). Unfortunately the diff is larger so harder to get merged. Please see if you can find any regressions if you have time.

Apr 06 '22 17:04 jeremypw

Thanks Jeremy! I'll take a look, probably this weekend.

Apr 07 '22 04:04 vjr

Closing as the linked issue is marked closed by another PR.

Aug 02 '23 15:08 jeremypw