code icon indicating copy to clipboard operation
code copied to clipboard
verified publisher icon elementary

Port to GTK4

Open danirabbit opened this issue 4 years ago • 4 comments

Things to do to prepare:

  • [x] Use Hdy.Tabbar
  • [x] Make Granite.SourceList Internal
  • [x] Replace Gtk.MenuItem with GLib.MenuModel

danirabbit avatar Dec 13 '21 20:12 danirabbit

Make Granite.SourceList Internal

So does this mean that Granite.SourceList should be moved into the elementary Code codebase?

colinkiama avatar Jan 10 '24 19:01 colinkiama

@colinkiama yes since there is no SourceList in Granite 7, Code will need its own sidebar class

danirabbit avatar Jan 11 '24 00:01 danirabbit

Things to do to prepare:

  • [ ] Use Hdy.Tabbar
  • [x] Make Granite.SourceList Internal
  • [ ] Replace Gtk.MenuItem with GLib.MenuModel

Does "Replace Gtk.MenuItem with GLib.MenuModel" include the SourceList widget? It's quite a bit of effort for something that will be completely be rewritten in the GTK 4 port. We also have the issue of Gtk.PopoverMenu not using elementary styling in GTK 3 (unless I'm missing something):

PopoverMenu in sidebar which has GNOME styling instead of the elementary widget styling

colinkiama avatar Apr 01 '24 00:04 colinkiama

@colinkiama you can use Glib.Menu with Gtk.Menu for Gtk3 and then the port from Gtk.Menu to Gtk.PopoverMenu in Gtk4 is much smaller than going from Gtk.MenuItem all the way to menu models at the same time. Basically just trying to break things down as much as possible into reviewable branches so we're not trying to merge a several thousand line diff that nobody can reasonably review

danirabbit avatar Apr 01 '24 04:04 danirabbit