code icon indicating copy to clipboard operation
code copied to clipboard

GlobalSearch: The dialog should be preloaded with the selected text (similar to searchbar)

Open jeremypw opened this issue 4 years ago • 3 comments

What Happened

  1. Select some text
  2. Press <Ctrl><Shift>F to open the global search dialog
  3. The dialog search entry is empty

Expected Behavior

The selected text should appear in the search entry in the same way and with the same restrictions as occurs when pressing <Ctrl>F for a local search

Steps to Reproduce

Logs

Platform Information

Elementary 6.0 daily

jeremypw avatar May 04 '21 14:05 jeremypw

Working on it.

igordsm avatar Sep 23 '21 00:09 igordsm

I think PR #1049 addresses this already? For some reason it was not linked to this issue.

jeremypw avatar Sep 23 '21 08:09 jeremypw

Well, at least my prototype is almost exactly equal to #1049 (except for the global search button). Thanks for the quick response.

On Thu, Sep 23, 2021 at 5:11 AM Jeremy Wootten @.***> wrote:

I think PR #1049 https://github.com/elementary/code/pull/1049 addresses this already? For some reason it was not linked to this issue.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/elementary/code/issues/1020#issuecomment-925593507, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABWCBSOGD6PCSYSAE5QRQDUDLOK5ANCNFSM44C3PPHQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Igor Montagner http://igormontagner.blogspot.com/

igordsm avatar Sep 23 '21 11:09 igordsm