calendar icon indicating copy to clipboard operation
calendar copied to clipboard

Fix meson warning for run_command

Open turbobastii opened this issue 3 years ago • 4 comments

Since I am already fixing the other repos with this issue, I thought I might do it here aswell.

TLDR: meson will change the default behaviour of run_command and displays that as a warning when building. See: https://github.com/mesonbuild/meson/issues/9300

image

turbobastii avatar Oct 01 '22 07:10 turbobastii

Don't we want it to be true?

tintou avatar Oct 01 '22 10:10 tintou

Well it was false implicitly by default, but if you think it would make more sense if it was true, I can of course change it.

turbobastii avatar Oct 01 '22 12:10 turbobastii

Well it was false implicitly by default

If the implicit default was generally good, then we (Meson) would not have deprecated it in the hope of eventually changing the default. :)

When adding an explicit value, it is wisest to consider what that value would be best served by being, rather than just explicating the default purely to quell the warning.

...

i.e. It's quite likely that if the command failed, the build is broken and will error out for quite mysterious reasons slightly later on -- best to validate it early...

eli-schwartz avatar Oct 02 '22 02:10 eli-schwartz

Very well put, thank you. I changed it accordingly.

turbobastii avatar Oct 02 '22 06:10 turbobastii