calculator icon indicating copy to clipboard operation
calculator copied to clipboard

Keyboard Support Redo

Open BAProductions opened this issue 2 years ago • 8 comments

https://github.com/elementary/calculator/pull/242

BAProductions avatar Mar 14 '23 00:03 BAProductions

@danirabbit

BAProductions avatar Mar 14 '23 00:03 BAProductions

If you're forwarding key events there's no reason to do all that manual key press handling

danirabbit avatar Mar 14 '23 00:03 danirabbit

Is there a reason you change the copy and paste logic? Is there maybe an issue we don't know about?

Yes because my entry is set to read only

BAProductions avatar Mar 14 '23 02:03 BAProductions

If you're forwarding key events there's no reason to do all that manual key press handling

Let me test this out

BAProductions avatar Mar 14 '23 13:03 BAProductions

If you're forwarding key events there's no reason to do all that manual key press handling

Can test my code just so I can make sure the nothing funny happening on my end? & second this how the Gnome Calculator is handal the key events as well

https://gitlab.gnome.org/GNOME/gnome-calculator/-/blob/master/src/math-display.vala#L124

BAProductions avatar Mar 14 '23 13:03 BAProductions

All the necessary have been made please review my code.

BAProductions avatar Mar 16 '23 14:03 BAProductions

@danirabbit

BAProductions avatar Mar 27 '23 18:03 BAProductions

Please be patient. You're not the only person waiting on me for a review :)

danirabbit avatar Mar 27 '23 18:03 danirabbit