appcenter icon indicating copy to clipboard operation
appcenter copied to clipboard

StripeDialog: Put the money icon in the right place depending on the locale

Open tintou opened this issue 4 years ago • 4 comments

In French we would write "5 $" and never "$ 5".

tintou avatar Sep 09 '21 07:09 tintou

I'm conflicted on this because we always put icons which describe the purpose of the entry in the primary position and it really messes up the layout to move it. It's more of a modifier to the entry itself than to number inside of the entry

danirabbit avatar Sep 15 '21 17:09 danirabbit

I feel like here the exception is that the icon is actually a label (using the same weight and font than a normal label) so it really looks weird for me as a french speaker.

tintou avatar Sep 15 '21 17:09 tintou

It's a different weight and font and spacing also :p

Screenshot from 2021-09-15 10 52 16

danirabbit avatar Sep 15 '21 17:09 danirabbit

@cassidyjames we're not using LC_MONETARY and I really don't know any software that actually use that, we just rely on the language

tintou avatar Sep 16 '21 06:09 tintou