element-desktop icon indicating copy to clipboard operation
element-desktop copied to clipboard

Draft: multiple accounts

Open alangecker opened this issue 3 years ago • 2 comments

first draft of multiple element instances in the same electron BrowserWindow.

Works so far, but there is still a lot to do (see ToDo list) and I can't promise that I'll find time for that in the next weeks 🙃

related vector-im/element-web#2320

Screenrecording showing switching between the instances

ToDo's

  • [ ] proper react menu with (webpack?) building
  • [ ] show badge counts in menu
  • [ ] aggregate badge counts for tray
  • [ ] open correct instance on notification click
  • [ ] make multiple profiles optional (via lab flag?)
  • [ ] apply a change in theme to all instances + menu
  • [ ] menu i18n
  • [ ] menu styling
  • [ ] instance chooser for protocol links
  • [ ] bring back electrons dropdown menu
  • [ ] accessibility
  • [ ] how to handle 'page-favicon-updated' and 'page-title-updated' now? (tray.ts)
  • [ ] tests
  • [ ] proper session partition naming, renaming possible?
  • [ ] migration of existing sessions

This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

alangecker avatar Aug 21 '22 11:08 alangecker

I get this error when compiling:

rc/seshat.ts:81:38 - error TS2345: Argument of type 'void' is not assignable to parameter of type 'string'.

81     const eventStorePath = path.join(instance.session.getStoragePath(), 'EventStore');
                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 1 error.

NebulaOnion avatar Sep 07 '22 17:09 NebulaOnion

nice! i think the UI should be iterated. instead of using yet another column for that which convolutes the UI, try using the already existing user button in the top left for switching accounts.

yuuyins avatar Oct 19 '22 11:10 yuuyins