element-android icon indicating copy to clipboard operation
element-android copied to clipboard

Fix VoiceRecorderLTests by faking OggOpusEncoder

Open jmartinesp opened this issue 3 years ago • 1 comments

Type of change

  • [ ] Feature
  • [ ] Bugfix
  • [ ] Technical
  • [x] Other : Fix broken tests.

Content

Used a fake OggOpusEncoder in VoiceRecorderLTests to fix some broken tests.

Motivation and context

VoiceRecorderLTests depended on the native Opus encoder to run. By using a fake and mimicking its behaviour we can avoid the tests failures we've seen in the CI.

Tests

  • Run VoiceRecorderLTests in the CI, see that they pass.

Tested devices

  • [ ] Physical
  • [x] Emulator
  • OS version(s): 13

Checklist

  • [ ] Changes has been tested on an Android device or Android emulator with API 21
  • [ ] UI change has been tested on both light and dark themes
  • [ ] Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
  • [x] Pull request is based on the develop branch
  • [x] Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
  • [ ] Pull request includes screenshots or videos if containing UI changes
  • [ ] Pull request includes a sign off
  • [x] You've made a self review of your PR
  • [ ] If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

jmartinesp avatar Sep 23 '22 14:09 jmartinesp