element-android icon indicating copy to clipboard operation
element-android copied to clipboard

[Device management] Rename a session (PSG-747)

Open mnaturel opened this issue 3 years ago • 2 comments

Type of change

  • [x] Feature
  • [ ] Bugfix
  • [ ] Technical
  • [ ] Other :

Content

Adding a new screen to rename a given session. It can be reached from the session overview screen using the overflow menu.

Motivation and context

Closes #7158

Screenshots / GIFs

Tests

  • Enable the new device manager feature flag
  • Go to Settings -> Security & Privacy -> Show all sessions (V2, WIP)
  • Press a session entry to go to a session overview
  • Press the overflow menu
  • Press the rename action
  • Check the focus is on the text field and the keaboard is opened when landing on the screen
  • Edit the name
  • Press the "Save" button
  • Check the session name is correctly updated everywhere
  • Press a session entry to go to a session overview
  • Press the overflow menu
  • Press the rename action
  • Edit the name
  • Press the close button
  • Check the session name has not been changed

Tested devices

  • [ ] Physical
  • [x] Emulator
  • OS version(s): Android 11

Checklist

  • [ ] Changes has been tested on an Android device or Android emulator with API 21
  • [x] UI change has been tested on both light and dark themes
  • [ ] Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
  • [x] Pull request is based on the develop branch
  • [x] Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
  • [x] Pull request includes screenshots or videos if containing UI changes
  • [ ] Pull request includes a sign off
  • [x] You've made a self review of your PR
  • [ ] If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

mnaturel avatar Sep 21 '22 09:09 mnaturel

Warnings
:warning:

vector/src/main/AndroidManifest.xml#L203 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion

:warning:

vector/src/main/AndroidManifest.xml#L203 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion

:warning:

vector/src/main/AndroidManifest.xml#L206 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion

:warning:

vector/src/main/AndroidManifest.xml#L206 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion

:warning:

vector/src/main/AndroidManifest.xml#L260 - Expecting android:screenOrientation="unspecified" or "fullSensor" for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices

:warning:

vector/src/main/AndroidManifest.xml#L260 - Expecting android:screenOrientation="unspecified" or "fullSensor" for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices

:warning:

vector/src/main/AndroidManifest.xml#L269 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

:warning:

vector/src/main/AndroidManifest.xml#L269 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

:warning:

vector/src/main/AndroidManifest.xml#L276 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

:warning:

vector/src/main/AndroidManifest.xml#L276 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

:warning:

vector/src/main/AndroidManifest.xml#L282 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

:warning:

vector/src/main/AndroidManifest.xml#L282 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

:warning:

vector/src/main/AndroidManifest.xml#L401 - Exported receiver does not require permission

:warning:

vector/src/main/AndroidManifest.xml#L401 - Exported receiver does not require permission

Generated by :no_entry_sign: dangerJS against 7a4bf83da0a14046609b02a25642d949f2f4ccce

ElementBot avatar Sep 23 '22 15:09 ElementBot