element-hq
App Layout - Toolbar shouldn't collapse with an empty list
Steps to reproduce
- Make sure the home screen has a height smaller than the viewport height
- Scroll down
Outcome
What did you expect?
For nothing to move as there's nothing to scroll
What happened instead?
The "all chats" header collapses and that feels odd as there's nothing to scroll. I believe we should prevent header collapse behaviour when the list height is smaller than the viewport height
Your phone model
No response
Operating system version
No response
Application version and app store
No response
Homeserver
No response
Will you send logs?
No
Are you willing to provide a PR?
No
reassigned to @ericdecanini, since he was implementing a toolbar and has more context about it
I checked this behaviour with a few other google apps with collapsing toolbars (specifically Google Drive, and Pixel 6 Pro's native Contacts and Files apps).
The behaviour is that the toolbar only becomes non-collapsible in an empty state (0 content). If there's even one piece of content in the list, even if it only takes up a small space in the whole viewport, the toolbar becomes collapsible.
Given that it's related to empty state, I'd like to do this as part of https://github.com/vector-im/element-android/issues/6754
I'll close this issue for now
@ericdecanini it's in done column on board but still open. What is the actual state?
I've investigated this and it seems extremely difficult for the value it provides. I personally don't think it's a problem for the toolbar to be collapsible in an empty state. Happy to hear your thoughts on this @daniellekirkwood @amshakal
Whether it's worth it for the value doesn't mean it should be in closed state if it's open... I'll move it to the correct column as it sounds like this is not actually done.
@ericdecanini I think you have a point and this is definitely not a blocker - however, we know that Design bugs tend to compound over time and lead to a bad user experience. You're right to tag @amshakal - do you think that it's a design bug and we should fix it, or should we leave it in the backlog as an enhancement?
It is not a blocker to release but exactly like you said, it compounds over time and leads to a bad user experience.
