element-android
element-android copied to clipboard
Adds Space List Bottom Sheet
Type of change
- [x] Feature
- [ ] Bugfix
- [ ] Technical
- [ ] Other :
Content
Adds Space List Bottom Sheet
Motivation and context
Closes https://github.com/vector-im/element-android/issues/6499
Not included in this PR:
- Toolbar changing text based on spaces switched
- Header text in bottom sheet being updated with hierachy of spaces
- Back and up navigation between spaces
- Empty states
Known bugs to be addressed separately:
Screenshots / GIFs
| Before | After | |
|---|---|---|
| Light | ![]() |
![]() |
| Dark | ![]() |
![]() |
| Black | ![]() |
![]() |
Video:
https://user-images.githubusercontent.com/20701752/183106253-e1be4e7a-a490-4940-9716-c10aa0bffe62.mp4
Tests
- Enable the New App Layout feature flag
- Click on the open spaces FAB
- See the bottom sheet and try navigating between spaces There is a known bug where the bottom sheet doesn't always measure properly. This will be addressed in TBA
Tested devices
- [x] Physical
- [ ] Emulator
- OS version(s): Android 12
Checklist
- [ ] Changes has been tested on an Android device or Android emulator with API 21
- [x] UI change has been tested on both light and dark themes
- [ ] Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
- [x] Pull request is based on the develop branch
- [x] Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
- [x] Pull request includes screenshots or videos if containing UI changes
- [ ] Pull request includes a sign off
- [x] You've made a self review of your PR
- [ ] If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()













