website icon indicating copy to clipboard operation
website copied to clipboard
verified publisher icon electron

Clicking "see more" of one of the card also stretches other card

Open mohantechnology opened this issue 3 years ago • 7 comments

In electron website governance page when clicked on "see more" of one of the card , then other cards also stretches to the height of the clicked card

https://user-images.githubusercontent.com/71864565/160682500-c4f04d14-92bf-43c1-90e0-5ca373009d90.mp4

is it made to behave like that ? or we can update it to work like below

https://user-images.githubusercontent.com/71864565/160850780-6b1d2180-30f0-483e-9edf-ee2022b48535.mp4

mohantechnology avatar Mar 29 '22 18:03 mohantechnology

@mohantechnology I think your option makes sense. @erickzhao what do you think?

molant avatar Mar 30 '22 17:03 molant

do i make a pull request regarding this changes ?

mohantechnology avatar Apr 01 '22 14:04 mohantechnology

yes, please!

molant avatar Apr 01 '22 15:04 molant

In below screenshots, height of card description is different for some card therefore , some "member" and "see more" horizontal position is not matched with their neighbour card Screenshot (4386)

so to fix this i have added a css class to handle height of card description . please take a look here and let me know if i have to make some changes .

after fixing final result is

https://user-images.githubusercontent.com/71864565/161445557-809b093c-c8ac-4a93-9afc-f4a0c8583bb6.mp4

mohantechnology avatar Apr 02 '22 00:04 mohantechnology

Hey @mohantechnology, can i make pull request to solve this problem??

rajpatelbot avatar Apr 16 '22 08:04 rajpatelbot

There's already a PR up for this. https://github.com/electron/electronjs.org-new/pull/202

erickzhao avatar Apr 18 '22 17:04 erickzhao

is this issue still open?

mdirfan40 avatar May 10 '24 07:05 mdirfan40