typescript-definitions

typescript-definitions copied to clipboard

IncomingMessage should implement ReadableStream

3

(Feel free to redirect me if this bug should be reported elsewhere.) The definition of `IncomingMessage` (generated from https://github.com/electron/electron/releases/download/v9.1.0/electron-api.json) fails to reflect the [documentation](https://www.electronjs.org/docs/api/incoming-message#class-incomingmessage)’s guarantee that “`IncomingMessage` implements the [Readable...

andersk

`addEventListener` calls the listener with `this` bound to the target. It takes `options?: boolean | AddEventListenerOptions` rather than just `useCapture?: boolean` as its third parameter, and returns `void` rather than...

andersk

Use `unknown` instead of `any`

4

`unknown` is the type-safe version of `any` and should be preferred. https://stackoverflow.com/questions/51439843/typescript-3-0-unknown-vs-any

sindresorhus

[Bug]: [Electron.d.ts][gn-typescript-definitions][Invalid type annotations] Electron.PrintToPDFOptions > Margins

3

### Preflight Checklist - [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project. - [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to. -...

eezz4