rcedit icon indicating copy to clipboard operation
rcedit copied to clipboard

RcEdit destroys application without relocation table

Open Macma77 opened this issue 8 years ago • 4 comments

One of the future in EurekaLog is to reduce file size by removing relocation table. When I set resources in such file RcEdit destroys application file.

In attachment I prepared simple application orginal with removed relocation table and one with resources applied via RcEdit (rcedit.exe EurekaLogRcEditTest.exe --set-version-string Test Test)

EurekaLogRcEditTest.zip

Macma77 avatar Dec 06 '17 07:12 Macma77

I'm also seeing issues with rcedit corrupting my executable after setting the version string. It could be this issue. Is it possible to get a fix?

thomasmfields avatar Feb 14 '18 13:02 thomasmfields

Same here. Happens when building Node.JS apps with pkg. Hope this could be fixed :)

erik-helmers avatar Apr 01 '19 10:04 erik-helmers

If anybody's wondering, pretty much all resource editing tools destroy the integrity of executable files except the latest version of resource hacker. Simply run the following command line to change an icon.

reshacker.exe -open "Your.exe" -save "Your.exe" -action addoverwrite -res "Your_icon.ico" -mask ICONGROUP,1,1033

I've tested every resource editor out there and this is the only one that worked.

m4heshd avatar Aug 19 '19 16:08 m4heshd

rcedit relies on the BeginUpdateResource/UpdateResource/EndUpdateResource winapi functions to do all the actual work of parsing and modifying the exe file format. I suspect those functions can't handle such .exe files. Which means this bug would have to be marked WontFix, because rcedit would have to be rewritten to fix it. Use ResourceHacker instead.

rversteegen avatar Sep 05 '21 14:09 rversteegen