build!: remove temporary shim
This was added in #1641 to temporarily provide a missing file that Forge relied on until a new Forge version was released with an updated version of Packager, so we don't need this anymore.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.09%. Comparing base (
224cc6a) to head (58f9495). Report is 3 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1698 +/- ##
=======================================
Coverage 89.09% 89.09%
=======================================
Files 17 17
Lines 899 899
Branches 187 187
=======================================
Hits 801 801
Misses 61 61
Partials 37 37
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Isn't there still potential for issues here, if a user updates their version of @electron/packager without updating their version of Forge? Since Forge indicates it can use any minor version of v18 of @electron/packager, so someone on Forge v7.2.0 could still have a need for this.
It's probably an unlikely situation, but maybe we just leave the shim until the next breaking change in Packager?
Yeah good point, this can wait for the next major release, enough inadvertent breaking changes on v18 😂
superseded by https://github.com/electron/packager/commit/8d64aa1777af1c714f7c9cd67aae7b132635e7fe