node icon indicating copy to clipboard operation
node copied to clipboard

Assess variables to emit in generated config.gypi

Open codebytere opened this issue 7 years ago • 3 comments

Assess which if any of the config variables are important to include in the js2c'd config.gypi generated by tools/generate_config_gypi.py.

/cc @nornagon

codebytere avatar Sep 28 '18 17:09 codebytere

I implemented a way to generate config.gypi using a Jinja2 template here to fix Node.js tests failures.

hashseed avatar Feb 02 '19 13:02 hashseed

Hm, jinja2 is an odd choice. config.gypi is just a python data structure, so repr() should be sufficient, no?

nornagon avatar Feb 04 '19 18:02 nornagon

I'm not a python guy. I just took it because we have it in DEPS anyways. I found replacing stuff in a template easier to read than programmatically altering an object like Node.js' configure script does.

hashseed avatar Feb 04 '19 22:02 hashseed