forge icon indicating copy to clipboard operation
forge copied to clipboard

feat: add upgrade reminder

Open DevanceJ opened this issue 1 year ago • 3 comments

  • [x] I have read the contribution documentation for this project.
  • [x] I agree to follow the code of conduct that this project follows, as appropriate.
  • [x] The changes are appropriately documented (if applicable).
  • [x] The changes have sufficient test coverage (if applicable).
  • [x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes: fixes #3091

uses update-notifier to remind user about new version of Forge.

DevanceJ avatar Apr 18 '24 08:04 DevanceJ

Hi @erickzhao I have used an older version of update-notifier in order to work with CommonJs, I have tried to work with the latest version of the library that supports CommonJs. Looking forward to your feedback.

DevanceJ avatar Apr 18 '24 08:04 DevanceJ

I see that some tests are failing. I'll look into it and let you know.

DevanceJ avatar Apr 18 '24 08:04 DevanceJ

The tests are failing because I used update-notifier as a dependency instead of devdependency. Please guide me on how to fix this.

DevanceJ avatar Apr 23 '24 00:04 DevanceJ