forge icon indicating copy to clipboard operation
forge copied to clipboard

Squirrel.Windows Maker requires version to be specified, whereas other makers do not

Open theosanderson opened this issue 3 years ago • 1 comments

When I don't specify version in package.json (which I know is not recommended) I get:

An unhandled error has occurred inside Forge:
An error occured while making for target: squirrel
Cannot read properties of undefined (reading 'split')
TypeError: Cannot read properties of undefined (reading 'split')
    at convertVersion (D:\a\taxonium\taxonium\taxonium_electron\node_modules\electron-winstaller\lib\index.js:56:25)

whereas other platforms don't give this error. This inconsistency seems undesirable.

~I believe this might be fixed by something like: https://github.com/electron/windows-installer/compare/master...theosanderson:windows-installer:patch-1?expand=1~ [ed: there is also at least some downstream usage]

theosanderson avatar Oct 12 '22 15:10 theosanderson

this post helped me fix an issue where version was not in package.json (using boilerplate from here perhaps a better error message could be returned when the version is missing (like when name is missing)

wallaceturner avatar Nov 21 '23 07:11 wallaceturner