fiddle icon indicating copy to clipboard operation
fiddle copied to clipboard

Error when npm is not installed in PATH

Open jschlade opened this issue 6 years ago • 3 comments

Seeing this error:

📦 Packaging current Fiddle...

Error: Could not find npm. Fiddle requires Node.js and npm to compile packages. Please visit https://nodejs.org to install Node.js and npm.

On Windows 10 x64. Using Fiddle app 0.6.0 with Electron v5.0.0 NodeJS installed to C:\Program Files\nodejs but not on path.

In Fiddle console I see this error below.

Any ideas?

Thanks

app.15fac660.js:2044 Fetch Types: Updating Monaco types with [email protected]
app.15fac660.js:252 getIsNpmInstalled: "where.exe npm" failed. Error: Command failed: where.exe npm
INFO: Could not find files for the given pattern(s).



    at ChildProcess.exithandler (child_process.js:299)
    at ChildProcess.emit (events.js:182)
    at maybeClose (internal/child_process.js:962)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:251)
getIsNpmInstalled @ app.15fac660.js:252

jschlade avatar May 03 '19 16:05 jschlade

Fiddle assumes that Node/NPM is in PATH. As a workaround, you should add it.

@felixrieseberg opinions on adding an optional setting to specify the location of NPM? Alternatively, we could update the error verbiage to mention adding Node/NPM to PATH.

malept avatar May 04 '19 15:05 malept

It's usually good practice to not depend on something to be in the PATH to work. This is the way old applications used to work. Not something as new and slick as Fiddle.

Fiddle doesn't have NodeJS built in? If so why not add what is needed to Fiddle directly?

Thanks

jschlade avatar May 04 '19 22:05 jschlade

NPM is kind of a big dependency to bundle with Fiddle.

malept avatar May 04 '19 22:05 malept