fiddle icon indicating copy to clipboard operation
fiddle copied to clipboard

chore: update electron-quick-start references

Open yangannyx opened this issue 6 months ago • 4 comments

This PR updates references to electron-quick-start to the renamed repo minimal-repro.

Fiddle currently uses electron-quick-start in the folder names of its template caching logic. I decided not to change this logic since it's internal to how fiddle operates and not something general electron consumers will be exposed to

yangannyx avatar Jul 02 '25 16:07 yangannyx

Coverage Status

coverage: 87.992% (+0.7%) from 87.282% when pulling 0ad093cbe89c466e6093c0416529a349c306d097 on anny/update-eqs-references into 56553bdf845604f03069f3a291428f30e91ca6ad on main.

coveralls avatar Jul 02 '25 17:07 coveralls

@yangannyx, I think this PR might be missing a commit? I don't see any actual changes to the electron-quick-start references.

dsanders11 avatar Jul 04 '25 04:07 dsanders11

@yangannyx, Is this PR still ongoing? If it is, it might be better to mark it as a Draft.

BlackHole1 avatar Jul 23 '25 02:07 BlackHole1

Hey @dsanders11 , @BlackHole1 apologies for the late reply. This PR is complete, it removes the electron-quick-start references in the mocks that are deleted in commit https://github.com/electron/fiddle/pull/1714/commits/6690c62d38e38da4d7d9111bda5946c659df4414. The remaining usages are in reference to the folder names where we cache copies of the minimal repro files for each electron major version. Since this is an implementation detail, I didn't think it was worth the lift of refactoring these folders to be migrated and prefixed minimal-repro instead of electron-quick-start. Let me know if you all think it's still a good idea!

yangannyx avatar Jul 29 '25 22:07 yangannyx