`ContextMenu` should be disabled in Settings page

Open aryanshridhar opened this issue 3 years ago • 9 comments

Noticed a minor issue of the Right click ContextMenu which is can be seen in Preference/Settings page as well.

May 10 '22 16:05 aryanshridhar

Probably we can disable the contextMenu property upon componentDidMount of settings page and then remove the listener when the component unmounts.

May 10 '22 16:05 aryanshridhar

@aryanshridhar would you be interested in opening a PR?

May 16 '22 07:05 codebytere

Cool! Opening up a pr for it!

May 19 '22 19:05 aryanshridhar

@aryanshridhar may I work on this issue?

May 21 '22 04:05 arya-vats

It's already assigned to @aryanshridhar so I'd leave it to him.

May 21 '22 19:05 erickzhao

@arya-vats Sure go ahead! I have already pushed the fix in my local branch earlier (https://github.com/aryanshridhar/fiddle/tree/Disable-ContextMenu) Use it as an reference if you need it :)

May 23 '22 18:05 aryanshridhar

@aryanshridhar thanks a lot! :)

May 23 '22 18:05 arya-vats

i am also work this issue

Sep 21 '22 08:09 vikeshk1234

contexMenu page #1115

Sep 21 '22 08:09 vikeshk1234