electron icon indicating copy to clipboard operation
electron copied to clipboard

feat: support `NODE_EXTRA_CA_CERTS`

Open codebytere opened this issue 1 year ago • 1 comments

Description of Change

Closes https://github.com/electron/electron/issues/41590

Adds missing support for NODE_EXTRA_CA_CERTS in Electron. It works as-is with OpenSSL & BoringSSL both - as evidenced by the workaround employed for devcontainers.

Also allows re-enabling of some disabled Node.js smoke tests.

Checklist

Release Notes

Notes: Added support for NODE_EXTRA_CA_CERTS.

codebytere avatar Mar 25 '24 13:03 codebytere

@MarshallOfSound gated it into the node options fuse

codebytere avatar Mar 25 '24 21:03 codebytere

API LGTM

nornagon avatar Mar 28 '24 23:03 nornagon

Release Notes Persisted

Added support for NODE_EXTRA_CA_CERTS.

release-clerk[bot] avatar Apr 10 '24 14:04 release-clerk[bot]

I was unable to backport this PR to "28-x-y" cleanly; you will need to perform this backport manually.

trop[bot] avatar Apr 10 '24 14:04 trop[bot]

I was unable to backport this PR to "29-x-y" cleanly; you will need to perform this backport manually.

trop[bot] avatar Apr 10 '24 14:04 trop[bot]

I was unable to backport this PR to "30-x-y" cleanly; you will need to perform this backport manually.

trop[bot] avatar Apr 10 '24 14:04 trop[bot]