electron
Treat PR approvals as API LGTMs
This should address an edge-case like the one seen in this PR: https://github.com/electron/electron/pull/42561
The scenario is:
- Someone requests changes on a PR
- That person then approves the PR without leaving an
API LGTMcomment
In that scenario, Cation sees the request for changes, but doesn't see the PR approval, and so it blocks the PR check due to the "pending" request for changes.
This PR updates the activity filtering to also consider PR approvals as equivalent to LGTM comments. This does also mean that anyone who approves a PR without adding an LGTM comment will also be counted toward the LGTM check.
IIRC we introduced the API LGTM concept as a way to clear the API Review check without explicitly approving the PR, in case someone only looked at the API but hadn't reviewed the implementation details, for example. With that intended meaning of the API LGTM comment system, it seems reasonable to treat a PR approval as equivalent to an API LGTM comment. Open to feedback, though, if others disagree 😅
Ya there's a similar discussion happening in the API WG about distinguishing between PR review and API review. I'll mark this as WIP until we reach consensus on the desired behavior.
Updated implementation and PR description to match the new approach we discussed in API WG. PR approvals/change requests are ignored, and instead only specific comment strings are used to approve/decline/request changes to the API.