brightray icon indicating copy to clipboard operation
brightray copied to clipboard

support --disk-cache-size flag

Open cjld opened this issue 9 years ago • 2 comments

I find out that the implementation of CreateHttpCacheBackendFactory, does not use the switch (--disk-cache-size=...), it set the cache size to zero, cause the cache size caculate by net::HttpCache::DefaultBackend and ignore the switch.

cjld avatar Apr 25 '17 10:04 cjld

--disk-cache-size is a chrome specific flag and hence wasn't implemented by default. There was already request in Electron for this flag https://github.com/electron/electron/issues/7713 . If you are interested to implement it, feel free to send a PR. Thanks!

deepak1556 avatar Apr 25 '17 15:04 deepak1556

It is worked for me. hope this PR could help!

cjld avatar Apr 26 '17 09:04 cjld