RedditVideoMakerBot icon indicating copy to clipboard operation
RedditVideoMakerBot copied to clipboard

Add custom resolution for background

Open HyptexPvP opened this issue 3 years ago • 5 comments

Is your feature request related to a problem? Please describe. Make the background much bigger so we can see the video in fullscreen if not uploaded on tiktok.

Describe the solution you'd like Allow the user to change the resolution / how big the video is.

HyptexPvP avatar Jul 10 '22 23:07 HyptexPvP

Hi, great suggestion. I will mark this enhancement as a good first issue . For newcomer, this could be done in the video_creation\final_video.py image

William9923 avatar Jul 11 '22 09:07 William9923

Hi, great suggestion. I will mark this enhancement as a good first issue . For newcomer, this could be done in the video_creation\final_video.py image

Also, is there i can make it big enough for something like YouTube?

HyptexPvP avatar Jul 12 '22 19:07 HyptexPvP

I've been attempting to work on this, and I'm almost done. The one issue I'm having is I'm not sure why I can't access the settings.config properly.

[settings.background] background_choice = "minecraft" width = 1080 height = 1920

I've modified the template file to also ask for the width and height, which is now stored under settings.background in the config.toml file properly. However, when I try to access it in final_video.py like this: W, H = settings.config["settings"]["background"]["width"], settings.config["settings"]["background"]["height"] I get

File "/Users/final/Desktop/RedditVideoMakerBot/video_creation/final_video.py", line 22, in W, H = settings.config["settings"]["background"]["width"], settings.config["settings"]["background"]["height"] TypeError: There are no type variables left in dict['settings']

thefinaloneg avatar Jul 16 '22 08:07 thefinaloneg

I've been attempting to work on this, and I'm almost done. The one issue I'm having is I'm not sure why I can't access the settings.config properly.

[settings.background] background_choice = "minecraft" width = 1080 height = 1920

I've modified the template file to also ask for the width and height, which is now stored under settings.background in the config.toml file properly. However, when I try to access it in final_video.py like this: W, H = settings.config["settings"]["background"]["width"], settings.config["settings"]["background"]["height"] I get

File "/Users/final/Desktop/RedditVideoMakerBot/video_creation/final_video.py", line 22, in W, H = settings.config["settings"]["background"]["width"], settings.config["settings"]["background"]["height"] TypeError: There are no type variables left in dict['settings']

Add it to the template file

JasonLovesDoggo avatar Jul 16 '22 17:07 JasonLovesDoggo

Hey, when are you calling the config? You must do it inside a function. The reason for this is because settings.py needs to run before you can access them.

AHopefulIdiot avatar Jul 29 '22 09:07 AHopefulIdiot