RedditVideoMakerBot icon indicating copy to clipboard operation
RedditVideoMakerBot copied to clipboard

Pydantic for settings template

Open electro199 opened this issue 8 months ago • 2 comments

Description

Use Pydantic for settings template and then in future use pydantic obj as config obj

  • All validation pattern supported via pydantic
  • Better templating and linting support

Issue Fixes

Confusing templating with toml

Checklist:

  • [ ] I am pushing changes to the develop branch
  • [ ] I am using the recommended development environment
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have formatted and linted my code using python-black and pylint
  • [ ] I have cleaned up unnecessary files
  • [ ] My changes generate no new warnings
  • [ ] My changes follow the existing code-style
  • [ ] My changes are relevant to the project

Any other information (e.g how to test the changes)

None

electro199 avatar Jun 09 '25 18:06 electro199

pydantic is a great choice. Just want to wait a bit to merge this. Would like lewis's PR in first

JasonLovesDoggo avatar Jun 11 '25 17:06 JasonLovesDoggo

Sure meanwhile I can update whole project to use the Pydantic config object. What are you thoughts ?

electro199 avatar Jun 11 '25 19:06 electro199

This pull request is stale as it has been open for 7 days with no activity. Remove stale label or comment, or this will be closed in 10 days.

github-actions[bot] avatar Jun 19 '25 00:06 github-actions[bot]

Pull request closed due to being stale.

github-actions[bot] avatar Jul 05 '25 00:07 github-actions[bot]