RedditVideoMakerBot icon indicating copy to clipboard operation
RedditVideoMakerBot copied to clipboard

[Bug]: Screenshots couldnt be taken error

Open definetelynotarobot opened this issue 1 year ago • 11 comments

Describe the bug

image "there was an error making the screenshots"

Reproduction Steps

run the app and observe that the error "something went wrong with screenshots" exists

Expected behavior

no error with screenshots and continue making the video.

Screenshots

image image image

System Information

Operating System : [e.g. Windows 10] Python version : [e.g. Python 3.10] App version / Branch : [e.g. latest, V3.3, master, develop]

Checklist

  • [X] I have searched the open issues for duplicates.
  • [X] I have shown the entire traceback, if possible.

Additional Context

No response

definetelynotarobot avatar Sep 20 '24 13:09 definetelynotarobot

#2129

Roostydoo2 avatar Sep 22 '24 07:09 Roostydoo2

I'm working on it to make a quick fix, the problem is due to reddit changes...

MohaMBS avatar Sep 22 '24 13:09 MohaMBS

#2129

Mentioning this other issue is clearly not needed as this is an error on prod. this was not fixed.

Also to add onto this, I'm also experiencing this issue.

Traceback (most recent call last):
  File "/home/lain/RedditVideoMakerBot/main.py", line 131, in <module>
    raise err
  File "/home/lain/RedditVideoMakerBot/main.py", line 113, in <module>
    run_many(config["settings"]["times_to_run"])
  File "/home/lain/RedditVideoMakerBot/main.py", line 68, in run_many
    main()
  File "/home/lain/RedditVideoMakerBot/main.py", line 52, in main
    get_screenshots_of_reddit_posts(reddit_object, number_of_comments)
  File "/home/lain/RedditVideoMakerBot/video_creation/screenshot_downloader.py", line 203, in get_screenshots_of_reddit_posts
    raise e
  File "/home/lain/RedditVideoMakerBot/video_creation/screenshot_downloader.py", line 180, in get_screenshots_of_reddit_posts
    location = page.locator('[data-test-id="post-content"]').bounding_box()
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/sync_api/_generated.py", line 14782, in bounding_box
    self._sync(self._impl_obj.bounding_box(timeout=timeout))
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/_impl/_sync_base.py", line 115, in _sync
    return task.result()
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/_impl/_locator.py", line 127, in bounding_box
    return await self._with_element(
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/_impl/_locator.py", line 108, in _with_element
    handle = await self.element_handle(timeout=timeout)
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/_impl/_locator.py", line 311, in element_handle
    handle = await self._frame.wait_for_selector(
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/_impl/_frame.py", line 323, in wait_for_selector
    await self._channel.send("waitForSelector", locals_to_params(locals()))
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/_impl/_connection.py", line 59, in send
    return await self._connection.wrap_api_call(
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/_impl/_connection.py", line 514, in wrap_api_call
    raise rewrite_error(error, f"{parsed_st['apiName']}: {error}") from None
playwright._impl._errors.TimeoutError: Locator.bounding_box: Timeout 30000ms exceeded.
Call log:
waiting for locator("[data-test-id=\"post-content\"]")

Motzumoto avatar Sep 22 '24 23:09 Motzumoto

I'm working on it to make a quick fix, the problem is due to reddit changes...

feel free to ping me either on discord or in a PR once you've made one

JasonLovesDoggo avatar Sep 23 '24 03:09 JasonLovesDoggo

I'm working on it to make a quick fix, the problem is due to reddit changes...

feel free to ping me either on discord or in a PR once you've made one

Today I will deploy the changes (it will not be a total fix, but a temporary one)

MohaMBS avatar Sep 23 '24 07:09 MohaMBS

Check my PR that solves this bug: https://github.com/elebumm/RedditVideoMakerBot/pull/2151 I hope it will be helpful

MohaMBS avatar Sep 23 '24 18:09 MohaMBS

This issue is stale because it has been open 7 days with no activity. Remove stale label or comment, or this will be closed in 10 days.

github-actions[bot] avatar Oct 01 '24 00:10 github-actions[bot]

i hope the update will fix this issue cus i have been same problem with screenshot as well

Superkaizhen07 avatar Oct 04 '24 03:10 Superkaizhen07

This issue is stale because it has been open 7 days with no activity. Remove stale label or comment, or this will be closed in 10 days.

github-actions[bot] avatar Oct 13 '24 00:10 github-actions[bot]

Check my PR that solves this bug: #2151 I hope it will be helpful

fixed it for me, also try to go easy on limitations in config.toml

definetelynotarobot avatar Oct 13 '24 11:10 definetelynotarobot

This issue is stale because it has been open 7 days with no activity. Remove stale label or comment, or this will be closed in 10 days.

github-actions[bot] avatar Oct 21 '24 00:10 github-actions[bot]

Issue closed due to being stale. Please reopen if issue persists in latest version.

github-actions[bot] avatar Nov 06 '24 00:11 github-actions[bot]