RedditVideoMakerBot icon indicating copy to clipboard operation
RedditVideoMakerBot copied to clipboard

Install script patch #1994

Open iaacornus opened this issue 1 year ago • 3 comments

Description

fixed #1994 which raised an error due to (pep 668)[https://peps.python.org/pep-0668/], however, instead of using the --break-system-packages flag to override the error, i thikn using pipx is a better solution.

there are other minor improvements made, but not biggy

Issue Fixes

#1994

Checklist:

  • [] I am pushing changes to the develop branch
  • [x] I am using the recommended development environment
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have formatted and linted my code using python-black and pylint
  • [x] I have cleaned up unnecessary files
  • [x] My changes generate no new warnings
  • [x] My changes follow the existing code-style
  • [x] My changes are relevant to the project

Any other information (e.g how to test the changes)

just run the script into ubuntu or other distro, should work, havent tested it tho

iaacornus avatar Apr 23 '24 11:04 iaacornus

Correct me if i'm wrong but pipx install does not have a -r arg.

i've addressed it in the lastest commit

iaacornus avatar Apr 26 '24 00:04 iaacornus

On Arch:

Installing...
Continue? (y/n)
y
Installing all
Installing required packages
warning: python-3.12.3-1 is up to date -- skipping
warning: python-pipx-1.5.0-2 is up to date -- skipping
warning: tk-8.6.14-3 is up to date -- skipping
warning: git-2.45.0-1 is up to date -- skipping
there is nothing to do
usage: python -m ensurepip [-h] [--version] [-v] [-U] [--user] [--root ROOT] [--altinstall] [--default-pip]
python -m ensurepip: error: unrecognized arguments: unzip
Installation failed

cyteon avatar May 10 '24 16:05 cyteon

On Arch:

Installing...
Continue? (y/n)
y
Installing all
Installing required packages
warning: python-3.12.3-1 is up to date -- skipping
warning: python-pipx-1.5.0-2 is up to date -- skipping
warning: tk-8.6.14-3 is up to date -- skipping
warning: git-2.45.0-1 is up to date -- skipping
there is nothing to do
usage: python -m ensurepip [-h] [--version] [-v] [-U] [--user] [--root ROOT] [--altinstall] [--default-pip]
python -m ensurepip: error: unrecognized arguments: unzip
Installation failed

this appears to be an error due to fault in arch's dep install function, latest commit fixed it. idk why the previous author tried to put unzip as an argument to python3 -m ensurepip, should be in sudo pacman -S. should work now.

iaacornus avatar May 13 '24 05:05 iaacornus