RedditVideoMakerBot icon indicating copy to clipboard operation
RedditVideoMakerBot copied to clipboard

Fix and improve TikTok TTS

Open jotonedev opened this issue 3 years ago • 4 comments

Description

Additional improvements to the pull request of jcolladosp.

  • Added new voices
  • Added the option to automatically choose the voice (done by TikTok API)
  • Added error handling
  • Added typing annotation for better readability
  • Also added more comments

Issue Fixes

  • TikTok TTS API

Checklist:

  • [x] I am pushing changes to the develop branch
  • [x] I am using the recommended development environment
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have formatted and linted my code using python-black and pylint
  • [x] I have cleaned up unnecessary files
  • [x] My changes generate no new warnings
  • [x] My changes follow the existing code-style
  • [x] My changes are relevant to the project

Any other information (e.g how to test the changes)

None

jotonedev avatar Sep 26 '22 16:09 jotonedev

Awesome! Did you test it?

OpenSourceSimon avatar Sep 30 '22 18:09 OpenSourceSimon

Yes, I tested it and it works.

jotonedev avatar Oct 01 '22 12:10 jotonedev

I don't see any documentation on how to get session ID

JasonLovesDoggo avatar Oct 01 '22 17:10 JasonLovesDoggo

I don't see any documentation on how to get session ID

I've made a pull request on the documentation repository

OpenSourceSimon avatar Oct 01 '22 17:10 OpenSourceSimon