RedditVideoMakerBot icon indicating copy to clipboard operation
RedditVideoMakerBot copied to clipboard

Minor changes to #990 (fixed audio glitches caused by previous audio concatenation method)

Open thomasmny opened this issue 3 years ago • 1 comments

Description

All credit for this PR goes to @tonywiththetommy

However his PR has been stale for a while and accumulated some merge conflicts so I decided to redo the PR in hope that it can be merged soon. Also adds silence_duration to the config template which upstream didn't.

Issue Fixes

Superceeds #990

Checklist:

  • [X] I am pushing changes to the develop branch
  • [X] I am using the recommended development environment
  • [x] I have performed a self-review of my own code
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] I have formatted and linted my code using python-black and pylint
  • [X] I have cleaned up unnecessary files
  • [x] My changes generate no new warnings
  • [X] My changes follow the existing code-style
  • [x] My changes are relevant to the project

Any other information (e.g how to test the changes)

None

thomasmny avatar Aug 18 '22 10:08 thomasmny

Will review later

JasonLovesDoggo avatar Aug 18 '22 17:08 JasonLovesDoggo

works perfectly thank you @Trichtern this is great

JasonLovesDoggo avatar Aug 22 '22 04:08 JasonLovesDoggo