react-pwa-reference-storefront icon indicating copy to clipboard operation
react-pwa-reference-storefront copied to clipboard

[WIP]Removed styled components dependency

Open rostyk-kanafotskyy opened this issue 5 years ago • 4 comments

Description:

Linting:

  • [ ] No linting errors

Tests:

  • [ ] E2E tests (npm test run with e2e)
  • [ ] Manual tests
  • [ ] Accessibility tests (no new react-axe errors in console)

Documentation:

  • [ ] Requires documentation updates
  • [ ] Requires Storybook component updates

rostyk-kanafotskyy avatar May 15 '20 10:05 rostyk-kanafotskyy

@shaunmaharaj @aChanEP Seems like it needs styled-components lib to work 😒 https://github.com/LucasBassetti/react-simple-chatbot/issues/157

rostyk-kanafotskyy avatar May 15 '20 11:05 rostyk-kanafotskyy

@aChanEP @rostyk-kanafotskyy Are we trying to remove styled-components to reduce the bundle size? Is code-splitting not enough for the chatbot component?

shaunmaharaj avatar May 15 '20 13:05 shaunmaharaj

@aChanEP @rostyk-kanafotskyy Are we trying to remove styled-components to reduce the bundle size? Is code-splitting not enough for the chatbot component?

Yes styled components gets bundled along with the chatbot. So removing it would make the bundle size smaller. I don't believe the initial load times would suffer because we've code split it so that it is downloaded asynchronously, but it will hinder how quickly the chatbot is able to be interacted with.

aChanEP avatar May 15 '20 14:05 aChanEP

@shaunmaharaj @aChanEP Seems like it needs styled-components lib to work 😒 LucasBassetti/react-simple-chatbot#157

All good! atleast now we know that we can't optimize here! I hope they make a fix. Thanks for looking into this :)

aChanEP avatar May 15 '20 14:05 aChanEP